Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

feat: add mnemonics to view switchers #742

Merged
merged 2 commits into from
Apr 2, 2023

Conversation

tiagoperrupato
Copy link
Contributor

Description

I added mnemonics to the labels that switch pages: "Colors",
"Monet" and "Advanced".
Still need to translate this feature to others languages
and I'd be glad to do that to Brazilian Portuguese. :)

Type of change

  • Bugfix (Change which fixes a issue)
  • New feature (Change which adds new functionality)
  • Enhancement (Change which slightly improves existing code)
  • Breaking change (This change will introduce incompatibility with existing functionality)

Changelog

  • Added
    • mnemonics to labels in initial page: "Colors", "Monet" and "Advanced"

Testing

  • I have tested my changes and verified that they work as expected

How to test the changes

To use this feature, you just need to press "alt" and it should highlight with an underline the options of mnemonics with shortcuts.
Than press the letter underlined in the option you choose to access.

I added mnemonics to the labels that switch pages: "Colors",
 "Monet" and "Advanced".
Still need to translate this feature to others languages,
 and I'd be glad to do that to Brazilian Portuguese. :)
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome on Gradience. 🥳 We really appreciate your contribution. The core team will review your pull request as soon as possible. You can also join the Matrix room: https://matrix.to/#/#Gradience-space:envs.net or the Discord server: https://discord.com/invite/4njFDtfGEZ.

@0xMRTT 0xMRTT requested a review from daudix March 22, 2023 20:26
@daudix
Copy link
Member

daudix commented Mar 22, 2023

@0xMRTT what is the difference between this and #741 ?

@0xMRTT
Copy link
Member

0xMRTT commented Mar 23, 2023

Honestly idk... That's the same... This one has just a more detailed change log.

There is something in common between the two guys... They speak Spanish...

Maybe we can merge this one with a mention to the other guy ?

Cc @marcos-evers @tiagoperrupato @daudix-UFO

@daudix daudix merged commit 6178de1 into GradienceTeam:main Apr 2, 2023
@daudix daudix mentioned this pull request Apr 2, 2023
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants