Update jdom dependency. Closes #98.

GradleUp · Nov 11, 2014 · c0fbcd9 · c0fbcd9
1 parent 519d2d4
commit c0fbcd9
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 8 deletions.
diff --git a/ChangeLog.md b/ChangeLog.md
@@ -2,6 +2,7 @@ v1.2.0
 ======
 
 + Re-organize some code to remove need for forcing the Gradle API ClassLoader to allow the `org.apache.tools.zip` package.
++ Upgrade JDOM library from 1.1 to 2.0.5 (change dependency from `jdom:jdom:1.1` to `org.jdom:jdom2:2.0.5`) ([Issue #98](https://github.com/johnrengelman/shadow/issues/98))
 
 v1.1.2
 ======

diff --git a/build.gradle b/build.gradle
@@ -32,7 +32,7 @@ dependencies {
 
     compile localGroovy()
     compile gradleApi()
-    compile 'jdom:jdom:1.1'
+    compile 'org.jdom:jdom2:2.0.5'
     compile 'org.ow2.asm:asm:4.1'
     compile 'org.ow2.asm:asm-commons:4.1'
     compile 'commons-io:commons-io:2.4'

diff --git a/...vy/com/github/jengelman/gradle/plugins/shadow/transformers/XmlAppendingTransformer.groovy b/...vy/com/github/jengelman/gradle/plugins/shadow/transformers/XmlAppendingTransformer.groovy
@@ -23,10 +23,14 @@ import com.github.jengelman.gradle.plugins.shadow.relocation.Relocator
 import org.apache.tools.zip.ZipEntry
 import org.apache.tools.zip.ZipOutputStream
 import org.gradle.api.file.FileTreeElement
-import org.jdom.*
-import org.jdom.input.SAXBuilder
-import org.jdom.output.Format
-import org.jdom.output.XMLOutputter
+import org.jdom2.Attribute
+import org.jdom2.Content
+import org.jdom2.Document
+import org.jdom2.Element
+import org.jdom2.JDOMException
+import org.jdom2.input.SAXBuilder
+import org.jdom2.output.Format
+import org.jdom2.output.XMLOutputter
 import org.xml.sax.EntityResolver
 import org.xml.sax.InputSource
 import org.xml.sax.SAXException

diff --git a/src/test/groovy/com/github/jengelman/gradle/plugins/shadow/TransformerSpec.groovy b/src/test/groovy/com/github/jengelman/gradle/plugins/shadow/TransformerSpec.groovy
@@ -430,13 +430,11 @@ class TransformerSpec extends PluginSpecification {
         String text = getJarFileContents(output, 'properties.xml')
         assert text.replaceAll('\r\n', '\n') == '''|<?xml version="1.0" encoding="UTF-8"?>
             |<!DOCTYPE properties SYSTEM "http://java.sun.com/dtd/properties.dtd">
-            |
             |<properties version="1.0">
             |  <entry key="key1">val1</entry>
             |  <entry key="key2">val2</entry>
             |</properties>
-            |
-        |'''.stripMargin()
+            |'''.stripMargin()
     }
 
     @Issue('SHADOW-82')