Fix compatibility with Gradle 2.5. Fixes #147 #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnrengelman
added a commit
that referenced
this pull request
Jul 17, 2015
Fix compatibility with Gradle 2.5. Fixes #147
|
Thanks for the PR. I'll try and get a new release out shortly. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted to upgrade my project to Gradle 2.5 today but noticed shadow was broken - because I wanted to continue the upgrade today I was looking into a fix for the problem. Basically Gradle 2.5 bundles only Maven 3 so the
plexus-utilsare no longer relocated in a different package.This changes the imports to the new (original) packages and adds a dependency on the original
plexus-utilswhich should (hopefully) maintain compatibility with older Gradle versions as well. While I have tested this successfully on Gradle 2.5, as well as some older Gradle versions like 2.4 and 1.12 I'm not completely sure if this will always work for older Gradle versions.The fix is probably not perfect, so if you've started already or see a better way feel free to close this, just thought it may help you to fix it a little bit faster. :)
Fixes #147