Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly add classifier to maven publication #904

Merged

Conversation

tha00
Copy link
Contributor

@tha00 tha00 commented Feb 11, 2024

It seems that after 960617f, archive classifiers are dropped from the archive file name due to the addition of the artifact via publication.artifact(File). According to the Gradle docs

Extension and classifier values are interpolated from the file name.

but for some reason it is not happening in ShadowExtension.

This PR provides a workaround by explicitly adding the classifier using the option to pass a Map to MavenPublication#artifact:

A Map that contains a 'source' entry that can be resolved as any of the other input types, including file. This map can contain a 'classifier' and an 'extension' entry to further configure the constructed artifact.

@tha00
Copy link
Contributor Author

tha00 commented Aug 8, 2024

@Goooler, do you have any objections to merging this PR, now that the move to GradleUp is done?

@Goooler
Copy link
Member

Goooler commented Aug 9, 2024

Will review this change carefully later.

@Goooler Goooler merged commit 3b97870 into GradleUp:main Sep 2, 2024
8 checks passed
@Goooler
Copy link
Member

Goooler commented Sep 2, 2024

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants