-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply legacy plugin last, and declare capabilities for old plugins #991
Apply legacy plugin last, and declare capabilities for old plugins #991
Conversation
The previous link worked but this is more correct
build-logic/src/main/kotlin/shadow.convention.publish.gradle.kts
Outdated
Show resolved
Hide resolved
CC @ljacomet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I said I would attempt this and in the end did not find the time.
This LGTM!
The one thing I wondered was about the capability addition: should it be done in a patch release or in a minor?
My preference would be to do it in a minor as it might end up breaking builds (for good reasons) while the fix to the order of application fits perfectly a patch release.
And thank you @jpenilla for taking care of fixing my mistake! |
I'm planning to release this in 8.3.4, WDYT? |
fixes #964 using the solution suggested by @ljacomet at #964 (comment)
Tested to fix the issue (bring behavior back to how it was before 8.3.1/with the old plugin), and to give an error when both the current and old plugin are on the classpath.
Something else that came to mind regarding the legacy plugin is that if someone puts the new plugin on the classpath, but then applies the legacy plugin id, nothing will happen, which could be confusing. But resolving that is likely better addressed in a separate PR (if at all).