Fixed saving position when some panel is outside the screen area https://github.com/GrandOrgue/grandorgue/issues/1271 #1342
Conversation
|
With this adjustment the behavior is different on Ubuntu (20.04). Earlier if multiple panels were partially outside the screen, one of them (and only one!) would center and the other moved just to edge of screen. Now, with this, the panels are not centered at all but moved to be visible (inside screen) just aligned at the closest edge. I don't really mind this behavior but it seems it's not quite what's intended. |
I installed ubuntu20 and I made tests with the old GO version (3.9.4-1) and with the new version (3.9.4-1.13) with this PR. Before After starting GrandOrgue 3.9.4-1: After starting GrandOrgue 3.9.4-13: So the new behavior is the same as you describe, but I could not reproduce the behavior you described with the old version. Earlier all panels
May be I intended restoring panels at the same positions where they were saved, but it is impossible with gnome shell: after GO opens all panels, gnome shell moves all panels to be fully visible. GrandOrgue can not distinguish moves are made by gnome shell from they are made by the user manually. The intended behavior works only on Windows, where the window manager is "less cleaver" than gnome shell. Whatever I find the new behavior is better than the old one, so I ask you to approve this PR. |
oleg68
force-pushed
the
bugfix/save-position-2
branch
from
6334e3a to
6e80194
Compare
|
@rousseldenis could you approve this PR? |
Resolves: #1271
This PR fixes restoring panel position if the frame was not fully inside the screen area.
It works fine on windows, but some window managers (ex. gnome-shell/mutter) return the panel inside the screen area if it is only partially visible.