Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split fatal and non-fatal errors, and change their presentation #39

Open
GrandyB opened this issue Mar 21, 2021 · 2 comments
Open

Split fatal and non-fatal errors, and change their presentation #39

GrandyB opened this issue Mar 21, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@GrandyB
Copy link
Owner

GrandyB commented Mar 21, 2021

Fatal errors would be those that prevent configs from being loaded, api key issues - anything to do with core config and overall sheet connection.

Non-fatal errors would include remote URLs returning 404, issues to do with individual cells. These are issues that shouldn't stop the flow of the application, nor flood the user with error popups; should be far less intrusive than that.

@GrandyB GrandyB added the enhancement New feature or request label Mar 21, 2021
@GrandyB GrandyB self-assigned this Mar 21, 2021
@GrandyB
Copy link
Owner Author

GrandyB commented Mar 21, 2021

Has become a more important issue given the introduction of #38 which will permit some errors in order to not interrupt the update loop.

@gitagogaming
Copy link

is this 'error handling' present in the current version?

I dont recall what version I'm on anymore.. and had an error occur the other day due to a file being misnamed which caused everything to disappear and made a real ugly experience...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants