Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling image file cell errors #46

Closed
GrandyB opened this issue Jan 28, 2023 · 1 comment
Closed

Handling image file cell errors #46

GrandyB opened this issue Jan 28, 2023 · 1 comment

Comments

@GrandyB
Copy link
Owner

GrandyB commented Jan 28, 2023

Is your feature request related to a problem? Please describe.
Right now, in order for a sheet to be properly ready for production, you have to add in a bunch of guards around cells that are an image source.
This is to prevent errors being thrown in your face and files not being updated when an image source cell is empty/malformed/has unexpected content.

These guards are annoying to constantly have to add in; would rather not need them and be a bit more permissive, instead writing out a transparent image in more scenarios.

Roughly related to #38 which added this in some form, and #39 .

Describe the solution you'd like
I'm thinking of changing the handling around this to the following:

  1. Empty image cell = transparent 50x50px image written, no error popup, debug log to say it has done that.
  2. Cell has "#N/A" as content = same as above.
  3. Cell with malformed URL or issue writing the image = error thrown in face.

Questions
Does the 50x50 need to be configurable? if so, application or config specific?
Would you rather have #N/A throw error in face?

GrandyB added a commit that referenced this issue Jan 28, 2023
If an image cell is empty or "#N/A", it'll output the 50x50 transparent
image in its place (and log it). Invalid URLs still give the popup.
@GrandyB
Copy link
Owner Author

GrandyB commented Feb 1, 2023

Released in 0.7.3

@GrandyB GrandyB closed this as completed Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant