refactor: reuse test setup for data sources #6099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
danstarns
commented
Aug 30, 2024
| // DocEl + Head + Wrapper | ||
| export const DEFAULT_CMPS = 3; | ||
|
|
||
| export function setupTestEditor() { |
There was a problem hiding this comment.
I think long term we should have the same function for each test we have, however for now as each test spawns a slightly different combination of editor and view etc, let's start with this and expand out.
There was a problem hiding this comment.
Yeah agree, in long term we can introduce more options to this helper
artf
approved these changes
Aug 31, 2024
| // DocEl + Head + Wrapper | ||
| export const DEFAULT_CMPS = 3; | ||
|
|
||
| export function setupTestEditor() { |
There was a problem hiding this comment.
Yeah agree, in long term we can introduce more options to this helper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the common test utils added in the Data Sources PR:
Related Comment: