generate html should keep id when script-export is set #6276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Singwai
changed the title
artf
approved these changes
Oct 31, 2024
|
Makes sense @Singwai thank you 🙇♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Question:
With cleanId enabled, should we check both script and script-export similar to match the js code generator logic in the html custom attributes function?
Here is the reference to ths jsGenerator. I think the getHtml code with cleanId might be have a chance to lost the id during export depending on the component's configuration.
Potential STR:
A component with script-export defined and script is empty
Without explicitly setting the id in the component attribute
Call
editor.getHtml({cleanId: true})