Support ObjectID in findByFields() #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `findByFields()` method could not find documents by a given ObjectID because the `stringToId()` function was only being run when querying for a field named `_id`. Since any MongoDB field could in theory contain an ObjectID, this broke queries looking for ObjectIDs in arbitrary fields. To resolve this, remove the condition testing for the field name of `_id` and run `stringToId()` on all values. This will validate whether a given String value is actually in the ObjectID format before proceeding, so it seems safe to apply everywhere. Fixes GraphQLGuide#65
|
Thanks for the fix! Published in |
|
You upgraded from |
|
@lorensr yes, I went from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
findByFields()method could not find documents by a given ObjectID because thestringToId()function was only being run when querying for a field named_id. Since any MongoDB field could in theory contain an ObjectID, this broke queries looking for ObjectIDs in arbitrary fields. To resolve this, remove the condition testing for the field name of_idand runstringToId()on all values. This will validate whether a given String value is actually in the ObjectID format before proceeding, so it seems safe to apply everywhere.The tests passed locally when I changed this implementation, which means there is probably something wrong with the mocks in the
cache.test.js...might be something to look into. This at least confirmed my belief as I was observing very different behavior in the real world than what the tests would have suggested.Fixes #65