Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print #77

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Print #77

wants to merge 1 commit into from

Conversation

sguerrini97
Copy link

I've added a menu option to print the document from the Uri.

@louipc
Copy link
Member

louipc commented Dec 29, 2020

Thanks. Should rebase your branch to remove those rename/revert commits.

@sguerrini97
Copy link
Author

@louipc done. I should've done it before opening this PR...

Anyway, I was wondering: what do you guys think about feeding the untrusted PDF to the print service?
It is also possible to print the rendered webview but during my tests this broke the PDF layout (e.g. zooming on the webview would result in a zoom on the final print, ruining the whole PDF concept).

@thestinger thestinger force-pushed the main branch 7 times, most recently from a66bb55 to c6113df Compare May 6, 2022 14:08
@thestinger thestinger force-pushed the main branch 3 times, most recently from 81c24e3 to 6a6a263 Compare June 6, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sguerrini97 @louipc