Skip to content

Commit

Permalink
ARCv2: SLC: Make sure busy bit is set properly on SLC flushing
Browse files Browse the repository at this point in the history
As reported in STAR 9001165532, an SLC control reg read (for checking
busy state) right after SLC invalidate command may incorrectly return
NOT busy causing software to NOT spin-wait while operation is underway.
(and for some reason this only happens if L1 cache is also disabled - as
required by IOC programming model)

Suggested workaround is to do an additional Control Reg read, which
ensures the 2nd read gets the right status.

Cc: stable@vger.kernel.org  #4.10
Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
[vgupta: reworte changelog a bit]
Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
  • Loading branch information
abrodkin authored and vineetgarc committed Mar 31, 2017
1 parent ae9955a commit c70c473
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions arch/arc/mm/cache.c
Original file line number Diff line number Diff line change
Expand Up @@ -633,6 +633,9 @@ noinline static void slc_entire_op(const int op)

write_aux_reg(ARC_REG_SLC_INVALIDATE, 1);

/* Make sure "busy" bit reports correct stataus, see STAR 9001165532 */
read_aux_reg(r);

/* Important to wait for flush to complete */
while (read_aux_reg(r) & SLC_CTRL_BUSY);
}
Expand Down

0 comments on commit c70c473

Please sign in to comment.