remove chunk of axed code, add comments

Graqr · May 22, 2024 · 4883ad3 · 4883ad3
1 parent 983f03a
commit 4883ad3
Showing 1 changed file with 3 additions and 8 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -42,14 +42,6 @@ jobs:
         path: ~/.m2
         key: ${{ runner.os }}-m2-${{ hashFiles('**/pom.xml') }}
         restore-keys: ${{ runner.os }}-m2
-#    - name: "󰙨 test & generate jacoco report"
-#      env:
-#        THRESHR_KEY: ${{ secrets.THRESHR_KEY }}
-#        THRESHR_CHANNEL: ${{ vars.THRESHR_CHANNEL }}
-#        TEST_DATASOURCES_DEFAULT_URL: ${{ secrets.TEST_DATASOURCES_DEFAULT_URL }}
-#        GITHUB_TOKEN: ${{ secrets.SONAR_GITHUB_TOKEN }}  # Needed to get PR information, if any
-#        SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
-#      run: mvn clean -Pcoverage sonar:sonar -Dsonar.projectKey=Graqr_Threshr
     - name: "SonarCloud Scan"
       env:
         THRESHR_KEY: ${{ secrets.THRESHR_KEY }}
@@ -60,3 +52,6 @@ jobs:
       run: |
         mvn -Pcoverage -Dmaven.verify.skip=true test org.sonarsource.scanner.maven:sonar-maven-plugin:sonar -Dsonar.projectKey=Graqr_Threshr
         mvn verify -Dmaven.verify.skip=true org.sonarsource.scanner.maven:sonar-maven-plugin:sonar -Dsonar.projectKey=Graqr_Threshr
+      # on windows, add double quotes like below
+      #.\mvnw -Pcoverage test org.sonarsource.scanner.maven:sonar-maven-plugin:sonar -Dsonar.projectKey=Graqr_Threshr
+      #.\mvnw verify org.sonarsource.scanner.maven:sonar-maven-plugin:sonar -D"sonar.projectKey=Graqr_Threshr"