Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce querying "product detail page" endpoint #53

Merged
merged 12 commits into from
Jan 22, 2024
Merged

introduce querying "product detail page" endpoint #53

merged 12 commits into from
Jan 22, 2024

Conversation

Jonathan-Zollinger
Copy link
Member

  • add a pull request template
  • remove unused database dependencies
  • update workflows
  • add new endpoint in client
  • add new client calls in controller (and overloaded version)
  • add very basic tests validating:
    • returned value isn't null
    • no error is thrown
    • methods accept Tcin args as tcin type and String value(s)

Jonathan-Zollinger and others added 12 commits January 21, 2024 20:09
@Jonathan-Zollinger
wip: add example responses from 3 target endpoints
3d3ac97 
Signed-off-by: jonathan zollinger <jonathan.zollinger@outlook.com>
@Jonathan-Zollinger
style: clean whitespace
c5a2abf 
Signed-off-by: Jonathan Zollinger <jonathan.zollinger@gmail.com>
@Jonathan-Zollinger
style: capitalize record name
17a88e2 
Signed-off-by: Jonathan Zollinger <jonathan.zollinger@gmail.com>
@Jonathan-Zollinger
refactor: change fetchProducts's return type
4a759e6 
Signed-off-by: Jonathan Zollinger <jonathan.zollinger@gmail.com>
@Jonathan-Zollinger
fix: deserialize product details object
76ce6c4 
Signed-off-by: Jonathan Zollinger <jonathan.zollinger@gmail.com>
@Jonathan-Zollinger
chore(build): bump version to 0.0.5 snapshot
13fd64f
@Jonathan-Zollinger
ci: point pr check at release branches
711f5a3 
Signed-off-by: Jonathan Zollinger <jonathan.zollinger@gmail.com>
@Jonathan-Zollinger
ci: add pr template
0f1779e 
Signed-off-by: Jonathan Zollinger <jonathan.zollinger@gmail.com>
@Jonathan-Zollinger
fix(build): remove db dependencies
76d5d7e 
Signed-off-by: Jonathan Zollinger <jonathan.zollinger@gmail.com>
@Jonathan-Zollinger
feat: overload method to accept strings
c45082d 
Signed-off-by: Jonathan Zollinger <jonathan.zollinger@gmail.com>
@Jonathan-Zollinger
refactor: make client package-private
36f97a6 
Signed-off-by: Jonathan Zollinger <jonathan.zollinger@gmail.com>
@Jonathan-Zollinger
test: add tests for prod summaries
272e3f3 
Signed-off-by: Jonathan Zollinger <jonathan.zollinger@gmail.com>
@Jonathan-Zollinger Jonathan-Zollinger merged commit 9834cc5 into release/0.0.5 Jan 22, 2024
2 checks passed
@Jonathan-Zollinger Jonathan-Zollinger deleted the feature/new-endpoints branch January 22, 2024 23:59
@Jonathan-Zollinger Jonathan-Zollinger restored the feature/new-endpoints branch January 23, 2024 03:14
@Jonathan-Zollinger Jonathan-Zollinger deleted the feature/new-endpoints branch January 27, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Jonathan-Zollinger