Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce "product details page" api endpoint support #54

Merged
merged 12 commits into from
Jan 23, 2024
Merged

Introduce "product details page" api endpoint support #54

merged 12 commits into from
Jan 23, 2024

Conversation

Jonathan-Zollinger
Copy link
Member

  • add a pull request template
  • remove unused database dependencies
  • add very basic tests validating:
    • returned value isn't null
    • no error is thrown
    • methods accept Tcin args as tcin type and String value(s)

Jonathan-Zollinger and others added 12 commits January 22, 2024 13:44
@Jonathan-Zollinger
chore(build): bump version to 0.0.5 snapshot
1784248
@Jonathan-Zollinger
ci: point pr check at release branches
3410982 
Signed-off-by: Jonathan Zollinger <jonathan.zollinger@gmail.com>
@Jonathan-Zollinger
ci: add pr template
d337f41 
Signed-off-by: Jonathan Zollinger <jonathan.zollinger@gmail.com>
@Jonathan-Zollinger
wip: add example responses from 3 target endpoints
3f805ba 
Signed-off-by: jonathan zollinger <jonathan.zollinger@outlook.com>
@Jonathan-Zollinger
style: clean whitespace
5dab966 
Signed-off-by: Jonathan Zollinger <jonathan.zollinger@gmail.com>
@Jonathan-Zollinger
style: capitalize record name
55cba8c 
Signed-off-by: Jonathan Zollinger <jonathan.zollinger@gmail.com>
@Jonathan-Zollinger
refactor: change fetchProducts's return type
e2a0ce9 
Signed-off-by: Jonathan Zollinger <jonathan.zollinger@gmail.com>
@Jonathan-Zollinger
fix: deserialize product details object
27cdbdd 
Signed-off-by: Jonathan Zollinger <jonathan.zollinger@gmail.com>
@Jonathan-Zollinger
fix(build): remove db dependencies
e679cd6 
Signed-off-by: Jonathan Zollinger <jonathan.zollinger@gmail.com>
@Jonathan-Zollinger
feat: overload method to accept strings
da10d3b 
Signed-off-by: Jonathan Zollinger <jonathan.zollinger@gmail.com>
@Jonathan-Zollinger
refactor: make client package-private
dff5423 
Signed-off-by: Jonathan Zollinger <jonathan.zollinger@gmail.com>
@Jonathan-Zollinger
test: add tests for prod summaries
9834cc5 
Signed-off-by: Jonathan Zollinger <jonathan.zollinger@gmail.com>
@Jonathan-Zollinger Jonathan-Zollinger merged commit 0500547 into main Jan 23, 2024
2 checks passed
@Jonathan-Zollinger Jonathan-Zollinger deleted the release/0.0.5 branch January 23, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Jonathan-Zollinger