Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/query target store #57

Merged
merged 4 commits into from
Feb 8, 2024

Conversation

Jonathan-Zollinger
Copy link
Member

Purpose of this Pull Request

Introduce ability to query target locations by zip code or city/state combo

How does this Pull Request address its purpose?

  • Add support for the 'nearby_stores_v1' redsky endpoint
    • add 'place' pojo to use as a query param in request

Iterate what tests have been added to maintain complete code coverage.

  • place.java's tests verify bad input can't be passed (bad zip codes, bad city + state combos, etc)
  • client and controller tests validate stores can be found when querying kosher zip / city+state strings

add feature sans tests
Signed-off-by: jonathan zollinger <jonathan.zollinger@outlook.com>
Signed-off-by: jonathan zollinger <jonathan.zollinger@outlook.com>
@Jonathan-Zollinger Jonathan-Zollinger added the enhancement New feature or request label Feb 8, 2024
@Jonathan-Zollinger Jonathan-Zollinger added this to the Harvester can target any target store for harvesting milestone Feb 8, 2024
@Jonathan-Zollinger Jonathan-Zollinger merged commit 15cdeca into release/0.0.6 Feb 8, 2024
2 checks passed
@Jonathan-Zollinger Jonathan-Zollinger deleted the feature/query-target-store branch March 1, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant