Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: override SearchRecommendations methods #99

Merged
merged 2 commits into from
Mar 18, 2024
Merged

fix: override SearchRecommendations methods #99

merged 2 commits into from
Mar 18, 2024

Conversation

Jonathan-Zollinger
Copy link
Member

@Jonathan-Zollinger Jonathan-Zollinger commented Mar 18, 2024 •
edited
Loading

fixes #94

@Jonathan-Zollinger
refactor: ignore .iml files
8a4c686 
Signed-off-by: jonathan zollinger <jonathan.zollinger@outlook.com>
@Jonathan-Zollinger
fix: override SearchRecommendations methods
4d9434e 
add custom methods for equals, hashCode and toString
this accommodates pojo array fields

Signed-off-by: jonathan zollinger <jonathan.zollinger@outlook.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Jonathan-Zollinger
Copy link
Member Author

note: my failure was from calling the sonar scan from my local machine at the same time, which didn't include a mvn verify call separate from the test call. the initial comment from the bot will note failure, but wait for the maven test to finish since that's where the jacoco report comes from.

@Jonathan-Zollinger Jonathan-Zollinger merged commit fac1ffb into release/0.0.10 Mar 18, 2024
3 checks passed
@Jonathan-Zollinger Jonathan-Zollinger deleted the fix/94 branch March 18, 2024 21:07
@Jonathan-Zollinger Jonathan-Zollinger restored the fix/94 branch March 25, 2024 20:07
@Jonathan-Zollinger Jonathan-Zollinger deleted the fix/94 branch March 25, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Jonathan-Zollinger