cosmos-sdk v0.45.8

[faddat]

Description

Hi :D

Just a PR here that brings the liquidity module current with cosmos-sdk v0.45.8

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

• Targeted PR against correct branch (see CONTRIBUTING.md)
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the module structure standards.
• Wrote unit and integration tests
• Updated relevant documentation (docs/) or specification (x/<module>/spec/)
• Added relevant godoc comments.
• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• Re-reviewed Files changed in the Github PR explorer
• Review Codecov Report in the comment section below once CI passes

[codecov-commenter]

Codecov Report

Merging #21 (b3b4288) into release/v1.5.1 (76ae711) will increase coverage by 0.02%.
The diff coverage is 71.42%.

@@                Coverage Diff                 @@
##           release/v1.5.1      #21      +/-   ##
==================================================
+ Coverage           33.24%   33.26%   +0.02%     
==================================================
  Files                  44       44              
  Lines               12503    12507       +4     
==================================================
+ Hits                 4156     4160       +4     
  Misses               7855     7855              
  Partials              492      492              

Impacted Files	Coverage Δ
app/export.go	13.18% <ø> (ø)
app/test_helpers.go	0.66% <0.00%> (ø)
x/liquidity/types/msgs.go	100.00% <ø> (ø)
x/liquidity/types/querier.go	0.00% <ø> (ø)
x/liquidity/simulation/operations.go	80.08% <100.00%> (+0.33%)	⬆️
x/liquidity/types/liquidity_pool.go	97.89% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[jaybxyz]

LGTM other than the failing lint check.

[jaybxyz]

Hey @faddat, we're planning to merge this PR sometime this week. It seems like to me that this PR doesn't have permission granted for maintainer(s) to directly commit changes. So I am asking you to make the following changes when you have time. As I test to fix the lint issue locally, I found the following issues that can be resolved.

• Remove the linter deadcode in golangci.yml as it is deprecated and replaced by unused.
• Fix // nolint:revive to //nolint:revive (no space in between)

[faddat]

totally!

Thanks for checking thorough this.

[faddat]

Random question:

When I make PR's from notional-labs repos, people cannot update them as you describe. When I make them as me, they can.

Do you have any idea how we can fix that?

[jaybxyz]

Did you allow "Allow edits from maintainers" check box when you open this PR? If you do, then owners of a project can directly push their commits to your PR.