Merge pull request #185 from GravityKit/hotfix/broken-value-objects

fix invalid type for callback

readme.txt

@@ -260,6 +260,7 @@ You can hide a row by adding a hook. Checkout this example:
 
 * Enhancement: Added security by requiring a secret for embedding the download link shortcode
 * Enhancement: Added embed shortcode copy section
+* Bugfix: Nested forms with missing entries could create a critical issue.
 
 = 2.1.0 on September 25, 2023 =
 

src/Transformer/Combiner.php

@@ -2,6 +2,7 @@
 
 namespace GFExcel\Transformer;
 
+use GF_Field;
 use GFExcel\Field\FieldInterface;
 use GFExcel\Field\RowsInterface;
 use GFExcel\Values\BaseValue;
@@ -59,8 +60,11 @@ public function parseEntry( array $fields, array $entry ): void {
 				continue;
 			}
 
-			// Multiple rows, so we need to combine, and we MUST have a StringValue object.
-			$combined = array_reduce( $values, static function ( string $output, BaseValue $value ): string {
+			$combined = array_reduce( $values, static function ( string $output, ?BaseValue $value ): string {
+				if ( ! $value ) {
+					return $output;
+				}
+
 				if ( $output !== '' ) {
 					$output .= gf_apply_filters( [
 						'gfexcel_combiner_glue',
@@ -74,7 +78,9 @@ public function parseEntry( array $fields, array $entry ): void {
 				return $output;
 			}, '' );
 
-			$combined_row[ $column ] = new StringValue( $combined, reset( $values )->getField() );
+			$gf_field = array_filter( $values ) ? reset( $values )->getField() : new GF_Field();
+
+			$combined_row[ $column ] = new StringValue( $combined, $gf_field );
 		}
 
 		$this->rows[] = $combined_row;