Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a unique key when embedding shortcode #190

Merged

Conversation

doekenorg
Copy link
Collaborator

This is a PR to address #189

  • It adds a security section where you can select whether to secure embed shortcodes.
  • It adds a section where you can copy the shortcode including the secret if it is set
  • It adds a gk/gravityexport/embed/is-protected to force protect EVERY tag (even for feeds that are already stored without this setting).

If the filter is used, protection cannot be overwritten for a specific form.

Security section:
Scherm­afbeelding 2024-01-24 om 14 42 36

Embed section:
Scherm­afbeelding 2024-01-24 om 14 13 05

@doekenorg doekenorg self-assigned this Jan 24, 2024
@mrcasual
Copy link
Collaborator

mrcasual commented Mar 7, 2024

@doekenorg, please review my changes. The rest looks good.

Copy link
Collaborator Author

@doekenorg doekenorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix these. But I think its good to know 😊

src/Shorttag/DownloadUrl.php Outdated Show resolved Hide resolved
src/Shorttag/DownloadUrl.php Outdated Show resolved Hide resolved
src/Shorttag/DownloadUrl.php Outdated Show resolved Hide resolved
src/Shorttag/DownloadUrl.php Outdated Show resolved Hide resolved
public/js/gravityexport-lite.js Outdated Show resolved Hide resolved
public/js/gravityexport-lite.js Outdated Show resolved Hide resolved
@doekenorg
Copy link
Collaborator Author

@mrcasual if you are happy with my review + solves, please merge. I'll try to release it today.

@mrcasual
Copy link
Collaborator

mrcasual commented Mar 7, 2024

@mrcasual if you are happy with my review + solves, please merge. I'll try to release it today.

Thanks. I'll merge, update the changelog and you can release.

@doekenorg doekenorg force-pushed the feature/189-add-a-unique-key-when-embedding-shortcode branch from 93c5a2b to ea27578 Compare March 7, 2024 13:48
@mrcasual mrcasual merged commit bbc16f3 into develop Mar 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants