Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSV character encoding #195

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Conversation

doekenorg
Copy link
Collaborator

This PR adds a hook to change the character encoding on a rendered CSV.

add_action( 'gfexcel_renderer_csv_output_encoding', function ( string $encoding ): string {
	return 'ISO-8859-1';
} );

I've use the gfexcel_ prefix to stay consistent instead of adding a new gk/gravityexport/... hook.

@doekenorg doekenorg requested a review from mrcasual July 4, 2024 09:16
@mrcasual mrcasual merged commit 769c827 into develop Jul 4, 2024
1 check passed
@mrcasual mrcasual deleted the feature/csv-character-encoding branch July 4, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants