Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress noisy notification in cloud #20968

Merged
merged 4 commits into from
Nov 26, 2024
Merged

Suppress noisy notification in cloud #20968

merged 4 commits into from
Nov 26, 2024

Conversation

patrickmann
Copy link
Contributor

@patrickmann patrickmann commented Nov 15, 2024

Fixes Graylog2/graylog-plugin-enterprise#8919

Description

See linked issue for details.

How Tested

  • Launch a multi-node OS cluster in docker
  • Find the node IDs by running docker ps
  • Stop one of the nodes by running docker stop nodeID
  • Observe that notification is triggered in master, but not in the fixed branch
  • Observe that log message is output in fixed branch

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@patrickmann patrickmann marked this pull request as ready for review November 22, 2024 11:52
@patrickmann patrickmann requested a review from a team November 22, 2024 11:55
Copy link
Contributor

@kodjo-anipah kodjo-anipah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, as expected.
Nit: maybe have the exceptional cases as a config so that its not hardcoded and changeable or extendable for further cases we might run into in the furture.

@patrickmann
Copy link
Contributor Author

Thx for the review. I prefer to wait with making things generic until there is actually more than 1 instance.

@patrickmann patrickmann merged commit 0edee90 into master Nov 26, 2024
8 checks passed
@patrickmann patrickmann deleted the cloudMaintenance branch November 26, 2024 11:20
janheise pushed a commit that referenced this pull request Nov 27, 2024
* suppress noisy notification in cloud

* CL

* adjust test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants