Upgrading to babel 7 - Take II #5151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a change in Babel 7 that affects resolution of babel configs[1] (`.babelrc` is now a hierarchical config, while `babel.config.js` is not), source files outside of the source root of jest will not be transpiled. That means, plugins running tests were not able to require/import source files of core. With this change, `.babelrc` will be renamed to `babel.config.js`, so it is still used when a plugin imports a file from core. [1]: jestjs/jest#6053 (comment)
dennisoelkers
changed the title
kmerz
approved these changes
Sep 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
This change is upgrading Babel to the most recent version. It involves bumping dependency versions and changing preset/plugin names. Due to stricter import checking, a minor issue with an import in the
OutputListwas noticed and fixed.Additionally to the changes in #5129 (which were reverted in #5146), this PR also includes:
.babelrctobabel.config.jsto enable running tests in plugins while importing modules from core (9ec6c86)envpreset to emitcjsmodules, to allowadd-module-exportsto add default-less exports for CommonJS-imports (usingrequire())How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: