Fix http input keep-alive handling #5728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were only responding to the first request on an http keep-alive connection with a 202. Any following requests would not be answered, leading to a timeout in the client. Configuring a ChannelFuture for CLOSE_ON_FAILURE did expose the reason for the bug: `io.netty.handler.codec.EncoderException: java.lang.IllegalStateException: unexpected message type: DefaultHttpResponse, state: 1` We ought to use `DefaultFullHttpResponse` instead of `DefaultHttpResponse`. Also keep the `CLOSE_ON_FAILURE` to make this more robust for future bugs. Fixes #5720
dennisoelkers
approved these changes
Mar 13, 2019
mpfz0r
added a commit
that referenced
this pull request
Mar 13, 2019
We were only responding to the first request on an http keep-alive connection with a 202. Any following requests would not be answered, leading to a timeout in the client. Configuring a ChannelFuture for CLOSE_ON_FAILURE did expose the reason for the bug: `io.netty.handler.codec.EncoderException: java.lang.IllegalStateException: unexpected message type: DefaultHttpResponse, state: 1` We ought to use `DefaultFullHttpResponse` instead of `DefaultHttpResponse`. Also keep the `CLOSE_ON_FAILURE` to make this more robust for future bugs. Fixes #5720 (cherry picked from commit 9f34e09)
dennisoelkers
pushed a commit
that referenced
this pull request
Mar 13, 2019
We were only responding to the first request on an http keep-alive connection with a 202. Any following requests would not be answered, leading to a timeout in the client. Configuring a ChannelFuture for CLOSE_ON_FAILURE did expose the reason for the bug: `io.netty.handler.codec.EncoderException: java.lang.IllegalStateException: unexpected message type: DefaultHttpResponse, state: 1` We ought to use `DefaultFullHttpResponse` instead of `DefaultHttpResponse`. Also keep the `CLOSE_ON_FAILURE` to make this more robust for future bugs. Fixes #5720 (cherry picked from commit 9f34e09)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were only responding to the first request on an http keep-alive connection with a 202.
Any following requests would not be answered, leading to a timeout in the client.
Configuring a ChannelFuture for CLOSE_ON_FAILURE did expose the reasonfor the bug:
io.netty.handler.codec.EncoderException: java.lang.IllegalStateException: unexpected message type: DefaultHttpResponse, state: 1We ought to use
DefaultFullHttpResponseinstead ofDefaultHttpResponse.Also keep the
CLOSE_ON_FAILUREto make this more robust for future bugs.Fixes #5720