Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CO2JS Model Implementation #10

Merged
merged 10 commits into from
Dec 7, 2023
Merged

CO2JS Model Implementation #10

merged 10 commits into from
Dec 7, 2023

Conversation

gnanakeethan
Copy link
Contributor

@gnanakeethan gnanakeethan commented Dec 5, 2023 •
edited
Loading

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

Implementation of CO2JS Model as specified in Green-Software-Foundation/if#156

@gnanakeethan
lib: adding co2js model
fbea298 
Signed-off-by: Gnanakeethan Balasubramaniam <gnanakeethan@users.noreply.github.com>
@gnanakeethan
unit: fixing unit tests for co2js
536d7ae 
Signed-off-by: Gnanakeethan Balasubramaniam <gnanakeethan@users.noreply.github.com>
@gnanakeethan
lint: fixes applied from yarn fix
00620f0 
Signed-off-by: Gnanakeethan Balasubramaniam <gnanakeethan@users.noreply.github.com>
@gnanakeethan gnanakeethan self-assigned this Dec 5, 2023
@gnanakeethan gnanakeethan linked an issue Dec 5, 2023 that may be closed by this pull request
Model Plugin - co2js Green-Software-Foundation/if#156
Closed
4 tasks
@gnanakeethan
unit: fixing unit tests
447d9e9 
Signed-off-by: Gnanakeethan Balasubramaniam <gnanakeethan@users.noreply.github.com>
@gnanakeethan
unit: coverage to 100%
a4e41c8 
Signed-off-by: Gnanakeethan Balasubramaniam <gnanakeethan@users.noreply.github.com>
@gnanakeethan gnanakeethan marked this pull request as ready for review December 6, 2023 09:20
@gnanakeethan
docs: adding documentation for co2js model
1ea353d 
Signed-off-by: Gnanakeethan Balasubramaniam <gnanakeethan@users.noreply.github.com>
jmcook1186
jmcook1186 approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
added some details to the README docs

@gnanakeethan
unit: fixes for organization
33c25e3 
Signed-off-by: Gnanakeethan Balasubramaniam <gnanakeethan@users.noreply.github.com>
@gnanakeethan
lib: remove unused values
d0ad1d3 
Signed-off-by: Gnanakeethan Balasubramaniam <gnanakeethan@users.noreply.github.com>
@jmcook1186 jmcook1186 mentioned this pull request Dec 6, 2023
Closed
6 tasks
@gnanakeethan
lib: fixes for logic
9cf1930 
unit: remove unused lines

Signed-off-by: Gnanakeethan Balasubramaniam <gnanakeethan@users.noreply.github.com>
@gnanakeethan gnanakeethan merged commit 71f82c4 into main Dec 7, 2023
2 checks passed
@gnanakeethan gnanakeethan deleted the co2js-model branch December 7, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmcook1186 jmcook1186 jmcook1186 approved these changes

@narekhovhannisyan narekhovhannisyan narekhovhannisyan approved these changes

Assignees

@gnanakeethan gnanakeethan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Model Plugin - co2js
3 participants
@gnanakeethan @narekhovhannisyan @jmcook1186