Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to pure functions #39

Merged
merged 70 commits into from
Mar 2, 2024
Merged

Refactor to pure functions #39

merged 70 commits into from
Mar 2, 2024

Conversation

manushak
Copy link
Contributor

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • refactor teads-curve plugin to pure function

@manushak manushak marked this pull request as draft February 12, 2024 12:52
@manushak
docs: renamed impact-engine to refactor
fd63a51
@manushak
feat: add plugins mapping
20c49d7
@manushak
fix: add config as a parameter to the execute function
a64f6e6
@manushak
docs: update the teads-curve doc
25eb59f
@manushak
feat(lib): update config part in teads-curve plugin
ae44af7 
-rename parameters
-remove unused types and mapping
-update test and doc
@manushak
feat(lib): refactor boavizta plugin into functional programming style
69debf4 
- rename input parameters
- renam base output file
@manushak
test: update boavizta test
c99b65a
@manushak
docs: update boavizta doc
ae91db3
@manushak
feat(lib): update exporting boavizta plugin
935ffdc
@manushak
feat(lib): refactor watt-time plugin to functional programming style
993cf5d 
- refacor watt-time API
@manushak
test: refactor watt-time test
a7b57e4
@manushak
docs: update watt-time readme file
bdd27b7
@manushak
feat(lib): refactor teads-aws plugin
eb2fc06
@manushak
test: update teads-aws test
40339a2
@manushak
docs: update teads-aws readme file
7c1813e
@manushak manushak linked an issue Feb 22, 2024 that may be closed by this pull request
Refactor models in if-unofficial-models repository Green-Software-Foundation/if#406
Closed
narekhovhannisyan and others added 15 commits February 28, 2024 20:30
@narekhovhannisyan
feat(config): add scope to commitlint
c85c285
@manushak
docs: rename IEF to IF
bdfeb0c
@manushak
fix(lib): update global and node configs validations in co2js
4da5654 
- update the doc
@manushak
docs: minor fix ib co2js plogin doc
2ff6a5b
@manushak
fix(lib): update return type of execute function in teads-aws
6555b3f 
- update the doc
@manushak
test: fix co2js test
5e5baaf
@manushak
fix(lib): update exporting WattTimeGridEmissions plugin
4b0c6ef
@manushak
fix(lib): fix validation in teads-curve
b052d49 
- update readme file
@narekhovhannisyan
chore(src): merge 'refactor-to-pure-functions' into refactor-to-pure-…
9a3ebcb 
…functions
@manushak
fix: rename IEF to IF, models to plugins
b16dd33
@manushak
Merge branch 'refactor-to-pure-functions' of https://github.com/Green…
5fa4671 
…-Software-Foundation/if-unofficial-models into refactor-to-pure-functions
@manushak
docs(lib): rename model to plugin remove new and add await keywords
3c0c2fe
@manushak
fix(lib): fix gelocation in watt-time plugin
94f501e 
- fix #479 and #478 bugs
- update the test
@manushak
fix(lib): update watt-time API's website link
334df21
@manushak
fix(lib): update Watt-time API's error response message
6d46ab0
@manushak manushak marked this pull request as ready for review February 29, 2024 11:19
@narekhovhannisyan narekhovhannisyan merged commit 60c528f into main Mar 2, 2024
2 checks passed
@narekhovhannisyan narekhovhannisyan deleted the refactor-to-pure-functions branch March 2, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariamKhalatova MariamKhalatova MariamKhalatova left review comments

@narekhovhannisyan narekhovhannisyan narekhovhannisyan approved these changes

@jmcook1186 jmcook1186 Awaiting requested review from jmcook1186

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor models in if-unofficial-models repository
4 participants
@manushak @narekhovhannisyan @MariamKhalatova @jmcook1186