Boavizta test coverage #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manushak
added
tests
manushak
requested review from
narekhovhannisyan,
jmcook1186 and
MariamKhalatova
| @@ -100,6 +129,36 @@ describe('lib/boavizta: ', () => { | |||
| expect(await output.execute([])).toEqual([]); | |||
| }); | |||
|
|
|||
| it('throws an error when the metric type is `gpu-util`.', async () => { | |||
There was a problem hiding this comment.
title says it's throws an error, but the implementation says it has result
| }, | ||
| ]); | ||
| } catch (error) { | ||
| expect(error).toBeInstanceOf(UnsupportedValueError); |
There was a problem hiding this comment.
please also assert the error message if possible
| @@ -64,6 +64,35 @@ describe('lib/boavizta: ', () => { | |||
| ]); | |||
| }); | |||
|
|
|||
| it('returns a result when the impacts from the API is undefined.', async () => { | |||
There was a problem hiding this comment.
why we are returning valid result if the API response is undefined?
There was a problem hiding this comment.
updated description. We set it to 0 in case of there isn't data from the API
narekhovhannisyan
approved these changes
Apr 4, 2024
MariamKhalatova
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
A description of the changes proposed in the Pull Request