Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Watt-time plugin #554

Closed
jmcook1186 opened this issue Mar 25, 2024 · 2 comments
Closed

Improve Watt-time plugin #554

jmcook1186 opened this issue Mar 25, 2024 · 2 comments
Assignees

Comments

@jmcook1186
Copy link
Contributor

Rationale

After deep diving the current plugin logic, I'm concerned we have inherited some poor design decisions and this plugin should be rebuilt from the ground up. Specifically:

  • We provide a single grid/carbon-intensity value for an entire input array regardless of the length or timespan of the array. We could be making an API request per observation or per N observations.
  • We have a hardcoded limit of 32 days for an input array. Currently, if the array covers > 32 day period we error out. This is because the WT API has this limit built in. However, we should support longer time series than 32 days, either by making multiple requests or using some fallback.
  • The mapping between wt regions and other plugins that return some version of a region (mockobs, importers etc) is complicated and hard to maintain, and the data itself needs auditing and updating.

Implementation details

  • Spike on WT as a team and determine the right logic we want to implement
  • Write new wt plugin specification
  • Build new plugin from spec

Priority

3/5
Out current version is not broken, it just has some unneccessary limits and unuual logic that can be improved.

Size

tbc

What does "done" look like?

tbc

Does this require updates to documentation or other materials??

Yes

Deadline

n/a

Acceptance criteria

tbc

@jmcook1186 jmcook1186 added this to IF Mar 25, 2024
@manushak manushak self-assigned this Mar 25, 2024
@manushak manushak moved this to In Progress in IF Mar 25, 2024
@manushak manushak moved this from In Progress to Pending Review in IF Apr 1, 2024
@MariamKhalatova MariamKhalatova moved this from Pending Review to Testing in IF Apr 1, 2024
@jmcook1186 jmcook1186 added this to the IF Sprint 9: 18/3/24 - 29/03/24 milestone Apr 2, 2024
@jmcook1186
Copy link
Contributor Author

@jmcook1186 jmcook1186 modified the milestones: IF Sprint 9: 18/3/24 - 29/03/24, IF Sprint 10: 2/4/24 - 12/04/24 Apr 8, 2024
@github-project-automation github-project-automation bot moved this from Testing to Done in IF Apr 9, 2024
@MariamKhalatova
Copy link
Contributor

tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants