Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow 0 and off values as input-parameter in Interpolation Plugin #1050

Merged
merged 11 commits into from
Oct 23, 2024
Merged

Allow 0 and off values as input-parameter in Interpolation Plugin #1050

merged 11 commits into from
Oct 23, 2024

Conversation

narekhovhannisyan
Copy link
Member

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

@narekhovhannisyan narekhovhannisyan self-assigned this Oct 15, 2024
@narekhovhannisyan narekhovhannisyan linked an issue Oct 15, 2024 that may be closed by this pull request
Accept both 0 and 'off' as inputs to interpolate builtin #1044
Closed
6 tasks
manushak
manushak reviewed Oct 16, 2024
View reviewed changes
src/if-run/lib/compute.ts Outdated Show resolved Hide resolved
@narekhovhannisyan @manushak
fix(lib): remove console.log
004a73f 
Co-authored-by: Manushak Keramyan <manushak.keramyan@gmail.com>
Signed-off-by: Narek Hovhannisyan <narekgilmour@gmail.com>
@narekhovhannisyan narekhovhannisyan merged commit 7011a2c into main Oct 23, 2024
2 checks passed
@narekhovhannisyan narekhovhannisyan deleted the 0-off-as-input branch October 23, 2024 09:41
@jmcook1186 jmcook1186 mentioned this pull request Oct 24, 2024
Open
@github-actions github-actions bot mentioned this pull request Oct 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmcook1186 jmcook1186 jmcook1186 approved these changes

@manushak manushak manushak approved these changes

Assignees

@narekhovhannisyan narekhovhannisyan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accept both 0 and 'off' as inputs to interpolate builtin
3 participants
@narekhovhannisyan @manushak @jmcook1186