Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #789 #1076

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Fix #789 #1076

merged 2 commits into from
Nov 22, 2024

Conversation

narekhovhannisyan
Copy link
Member

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

A description of the changes proposed in the Pull Request

  • Handled yaml reading and saving errors.

@narekhovhannisyan narekhovhannisyan self-assigned this Nov 19, 2024
@narekhovhannisyan narekhovhannisyan linked an issue Nov 19, 2024 that may be closed by this pull request
Receiving the same error message twice #789
Closed
jmcook1186
jmcook1186 approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

@narekhovhannisyan narekhovhannisyan merged commit 4ab5ad2 into main Nov 22, 2024
2 checks passed
@narekhovhannisyan narekhovhannisyan deleted the fix-#789 branch November 22, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmcook1186 jmcook1186 jmcook1186 approved these changes

@manushak manushak Awaiting requested review from manushak

Assignees

@narekhovhannisyan narekhovhannisyan

Labels
None yet
Projects
IF
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Receiving the same error message twice
2 participants
@narekhovhannisyan @jmcook1186