Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aggregate tests #563

Merged
merged 2 commits into from
Mar 31, 2024
Merged

Aggregate tests #563

merged 2 commits into from
Mar 31, 2024

Conversation

narekhovhannisyan
Copy link
Member

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • Implemented tests for aggregation lib.

jmcook1186
jmcook1186 approved these changes Mar 29, 2024
View reviewed changes
Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jmcook1186 jmcook1186 added this to the IF Sprint 9: 18/3/24 - 29/03/24 milestone Mar 29, 2024
@MariamKhalatova MariamKhalatova merged commit 0bc946b into main Mar 31, 2024
2 checks passed
@MariamKhalatova MariamKhalatova deleted the aggregate-tests branch March 31, 2024 05:28
@manushak manushak mentioned this pull request Apr 1, 2024
Closed
This was referenced May 17, 2024
Closed
Merged
@github-actions github-actions bot mentioned this pull request Jun 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariamKhalatova MariamKhalatova MariamKhalatova approved these changes

@jmcook1186 jmcook1186 jmcook1186 approved these changes

@manushak manushak Awaiting requested review from manushak

Assignees

@narekhovhannisyan narekhovhannisyan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@narekhovhannisyan @jmcook1186 @MariamKhalatova