-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
training docs + images translated in IT (italian) #151
training docs + images translated in IT (italian) #151
Conversation
I kept the same exact structure and tried to fit 100% of meaning with the translation. I left some original words where here in Italy is better to us them as they are (i.e. "overhead"). For the folder structure, I've just created an "it" subfolder waiting to rearrange them according to the web framework or design requirements
that's great !!! Please merge asap :) |
@childotg @nomed hi and thanks for contributing to our project. please allow us time to review your contribution. as mentioned to @childotg via email earlier, we were not planning to add translations. but we are happy to look at this as soon as our capacity allows. @greenhsu123 pls review on a high level asap. thank you! |
This is great to see :) Thank you so much @childotg!! @holanita - could you please add this as an item for discussion at our meeting tomorrow? Specifically, on the review and validation process for non-English contributions? Could you also ping the foundation's web developer to see how he would like to manage different language content, so we are consistent with the rest of the foundation's projects? |
To be discussed tomorrow for sure. I think we can only proceed when our capacity allows which is currently very limited. |
This looks amazing thanks for your input @childotg! @greenhsu123 and @holanita - the thing to consider here is ongoing maintenance, if we start accepting translations then what's our process for updates in the future? For content that doesn't update often (e.g. a blog article) I don't think this is a problem but for content that is going to evolve like this training we should have a process for accepting translations. Questions to ask:
I've had the same problem with principles.green, how to handle translations on open source content without having the translated content go out of date? Microsoft translates every word in their online docs to I think 40+ languages, every change I would make would kick off this huge engine which included sending my change to a range of humans that would translate it and then check that change back into GH. The pattern we choose here should probably be the pattern we employ across all our projects. |
@jawache Thank you for considering this. I'm adding my comments despite not explicitly asked: I think a good way to start can be the combination of points 2 and 3. I mean, the localized content can be marked as "community" AND we can setup a versioning in the MDs with some sort of action triggered in case of languages left behind. |
Thanks @childotg 2 + 3 would be ideal, docusaurus does have a versioning feature - I'm not 100% how it interacts with translations however, https://docusaurus.io/docs/versioning Would you mind trying it out, I presume you have this all checked our locally? Also let me ask our web dev @osamajandali about the disclaimer, @osamajandali would it be possible to show a disclaimer banner, like the one of the top of this page: https://sci-data.greensoftware.foundation/ - for just some of the pages for a docusaurus website? Like maybe if it was a flag in the front matter. Or something more complex so the front matter for translates content has to have the version number of the english content it was translated against and then shows the banner if there is a mismatch? |
In the 32b6541 commit I proposed the i18n implementation following standard rules plus docusaurus guidelines, to be then compliant to the versioning framework. In details:
|
That's wonderful thanks @childotg! Ok so @greenhsu123 if you're comfortable with the below approach so am I:
|
@jawache I can do the versioning as well if it's okay for you. I've just made an intro commit to prepare things. If everything's alright with the approach, you can just enroll the content checker and the disclaimer and I think about the versioning! |
I am happy with the combination of 2 and 3. @childotg, thanks again for such great work! And let us know when you have a working version of the versioning, and I will check them out locally then! |
Thats great, @zanete can you make sure to cover this in the weekly web meeting with Osama? |
Dear @jawache @holanita in this commit 559a1cf is also versioned as v1.0.0.
As a suggestion, since now the structure has changed a bit due to versioning, changing now the main branch docs should be postponed to the merge, to avoid a complex merge |
Hey @osamajandali and @zanete, can you acknowledge receipt of this? |
Hey, @jawache sorry for the late response. There is a better way that I think is a best practice, to have a banner that says "Unreleased" you can see it on docusaurus main website, but this solution is tide to a version not per page. So for example you can have a similar banner that says that the Italian version is unreleased yet. I see that @childotg is implementing the versioning so then I recommend that we go in with this banner. To read more about versioning configuration from here Let me know what direction you want to go, and @childotg if you need any help implementing the versioning, please let me know. |
Thanks @osamajandali for the clarification. By my side the versioning is implemented and ready to merge! |
@jawache let us know whether you'd like @osamajandali
|
The text does need to be more specific regarding the nature of the content and the support level, e.g. the text should read something like "This is a community translation with limited support". Is that possible with the proposed approach? @osamajandali / @zanete |
@osamajandali @jawache we can even put the disclaimer on every translated page. Scrappy but effective. |
Oh true actually, just put the text on there with an admonition. "This translation is a community translation, it has limited support and might not be up to date with the latest version in English" We should put somewhere the version of the English version this translation is made against so in the future we can compare and see what commits need to be mirrored to this version to match. Either in the disclaimer about or in front matter, i'm very open to suggestions! |
Done
It is already in place with versioning, I'm pasting a screenshot. If we merge (those changes with the versioning already in place were not so clean) we can then fine tune of course: |
@jawache @childotg I was going to propose the same approach @childotg do, to put manually in every page. |
Thanks ok so this makes sense. The only question I have now is about versioning, I don't think given the approach we are discussing now, versioning the 'whole' project makes sense anymore. Since now if we just update the English version, the version might incr. to 1.01 and then the Italian and English version both show v1.01 which gives the impression they are in sync.
Thoughts @childotg / @osamajandali ? |
@jawache I believe the same, there is no need for versioning. |
I'm removing @osamajandali as assignee from this issue as it looks like it's resolved without need of further dev? |
I, childotg <child@ocdstudio.net>, hereby add my Signed-off-by to this commit: 573dbe3 I, childotg <child@ocdstudio.net>, hereby add my Signed-off-by to this commit: 32b6541 I, childotg <child@ocdstudio.net>, hereby add my Signed-off-by to this commit: 559a1cf I, childotg <child@ocdstudio.net>, hereby add my Signed-off-by to this commit: 7c53b49 Signed-off-by: childotg <child@ocdstudio.net>
I, Roberto Freato <child@ocdstudio.net>, hereby add my Signed-off-by to this commit: 553d8aa Signed-off-by: Roberto Freato <child@ocdstudio.net> Signed-off-by: childotg <child@ocdstudio.net>
I, Roberto Freato <child@ocdstudio.net>, hereby add my Signed-off-by to this commit: 553d8aa Signed-off-by: Roberto Freato <child@ocdstudio.net>
I, childotg <child@ocdstudio.net>, hereby add my Signed-off-by to this commit: a571752 Signed-off-by: childotg <child@ocdstudio.net>
I, Roberto Freato <child@ocdstudio.net>, hereby add my Signed-off-by to this commit: 553d8aa Signed-off-by: Roberto Freato <child@ocdstudio.net>
@zanete ok but didn't get if @osamajandali o @jawache would like to remove versioning before merge. I would suggest to keep versioning and see how it works in production. We can even remove it later I guess |
Ahh sorry to ask this one last thing of you @childotg but can we remove the versioning? I think it's going to add confusion/needs more thought. |
Signed-off-by: Roberto Freato <child@ocdstudio.net>
@greenhsu123 and @Oleg-Zhymolokhov can we discuss this in todays meeting? |
As discussed in the meeting, happy to approve! @childotg, thanks again for your contribution :) |
Hi |
Hi @Jjing-Liang, thank you so much for reaching out about translating green software principles into Chinese! As this MR is closed, let's move this discussion to here. |
I kept the same exact structure and tried to fit 100% of meaning with the translation. I left some original words where here in Italy is better to us them as they are (i.e. "overhead"). For the folder structure, I've just created an "it" subfolder waiting to rearrange them according to the web framework or design requirements