Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command interface improvements #10

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Conversation

wwoytenko
Copy link
Contributor

@wwoytenko wwoytenko commented Feb 9, 2024

Command interface improvements

  • Introduced temporal solution for Column container. Greenmask has a few transformers with parameters that are lists of objects that point out on the columns of the table. For correct list-transformers and show-transformer command print the IsColumnContainer property is introduced. This later will raise the feature implementation task for "Container" parameters introspection.
  • Reduced output in list-transformers command. Now it prints only the transformer name, description, and column parameters
  • Added show-transformer command that prints details about transformer found by name provided
  • Fixed list-dump, list-transformers, and restore commands exit code on error
  • Refactored code

* Introduced temporal solution for Column container. Greenmask has a few transformers with parameters that are lists of objects that point out on the columns of the table. For correct `list-transformers` and `show-transformer` command print the IsColumnContainer property is introduced. This later will rise the case for "Container" parameters introspection.
* Reduced output in list-transformers command. Now it prints only the transformer name, description, and column parameters
* Added `show-transformer` command that prints details about transformer found by name provided
* Fixed list-dump, list-transformers, and restore commands exit code on error
@wwoytenko wwoytenko added bug Something isn't working enhancement New feature or request labels Feb 9, 2024
@wwoytenko wwoytenko requested a review from gracingpro February 9, 2024 21:21
@wwoytenko wwoytenko self-assigned this Feb 9, 2024
Copy link
Contributor

@gracingpro gracingpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works perfectly.

@gracingpro gracingpro merged commit 7a87922 into release_0_1_5 Feb 12, 2024
14 checks passed
@wwoytenko wwoytenko deleted the transformer_introspection branch February 16, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants