Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implemented Inserts with ON CONFLICT DO NOTHING and more #157

Merged
merged 7 commits into from
Aug 17, 2024

Conversation

wwoytenko
Copy link
Contributor

@wwoytenko wwoytenko commented Aug 13, 2024

  • Fixed error handling in the restore command.
  • Now, restore jobs initiate a transaction for each table restoration.
  • Implemented insert commands based on COPY format data.
  • Added support for ON CONFLICT DO NOTHING.
  • Implemented errors exclusion for insert-like commands
  • Implemented full --exit-on-error support for data section
  • Fixed an issue where an error in a subsequent restoration task could potentially rollback data inserted during a previous task
  • Introduced the --restore-in-order parameter for the restore command, which enforces restoration in topological order. This is useful when all references and constraints are deployed, and we only need to restore the data
  • Refactored the restore and dump command code by decomposing it into simpler functions.
  • Removed the code responsible for toc.Entry reception; now, []*toc.Entry is generated directly based on the context.

TODO:

  • Need to write a doc - DONE
  • Restore tables in topological order - DONE
  • Implement a restoration controller that distributes table restoration tasks across workers, ensuring that dependent tables are only restored after all the tables they depend on have been successfully restored - DONE
  • Add warning that constraint might be violated in restore command for restore-in-order parameter - DONE

Closes #153

* Fixed error handling in the restore command.
* Now, restore jobs initiate a transaction for each table restoration.
* Implemented insert commands based on COPY format data.
* Added support for ON CONFLICT DO NOTHING.
* Implemented errors exclusion for insert-like commands
* Implemented full --exit-on-error support for data section
* Fixed an issue where an error in a subsequent restoration task could potentially rollback data inserted during a previous task
* Introduced the --topological-order parameter for the restore command, which enforces restoration in topological order. This is useful when all references and constraints are deployed, and we only need to restore the data
* Refactored the restore and dump command code by decomposing it into simpler functions.
* Removed the code responsible for toc.Entry reception; now, []*toc.Entry is generated directly based on the context.
* Added reversed condensed graph
* Renamed parameter name
* Implemented dependencies check coordinator when restore command runs with --restore-in-order
* added documentation for new features
* restructured commands documentation format
fixed the case when condensed graph is not built when subset is not provided
@wwoytenko wwoytenko merged commit 1b34a99 into main Aug 17, 2024
15 checks passed
@wwoytenko wwoytenko deleted the feat/restore_insert_format branch August 30, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use on-conflict-do-nothing flag due to other missing flags that cannot be supplied
1 participant