Fix skipping unknown type when silent is true #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwoytenko
requested changes
Dec 6, 2024
| Int("Oid", int(t.Oid)). | ||
| Str("Kind", fmt.Sprintf("%c", t.Kind)). | ||
| Msg("unable to register domain type") | ||
| } | ||
| continue | ||
| } | ||
| typeMap.RegisterType(&pgtype.Type{ |
There was a problem hiding this comment.
Could you add fix for Array type registering as well (it's below) ?
wwoytenko
requested changes
Dec 6, 2024
pkg/toolkit/types.go
Outdated
| Str("Name", t.Name). | ||
| Int("Oid", int(t.Oid)). | ||
| Msg("cannot register array type for custom type") | ||
| continue |
There was a problem hiding this comment.
Looks like continue should be after if !silent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying Greenmask on a more complex DB (musicbrainz) and it was crashing in this code. It seems that the issue is that when silent is true, the type is not actually skipped.
I opened a PR directly in case it's this simple, but if you'd rather have me open an issue instead, I'm happy to.