Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs and networking quality of life improvements #523

Merged
merged 12 commits into from
Apr 26, 2024
Merged

Fix bugs and networking quality of life improvements #523

merged 12 commits into from
Apr 26, 2024

Conversation

Copy link

github-actions bot commented Apr 26, 2024

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 58.75000% with 99 lines in your changes are missing coverage. Please review.

Project coverage is 32.48%. Comparing base (d6fb3bf) to head (125093d).

❗ Current head 125093d differs from pull request most recent head 39205df. Consider uploading reports for the commit 39205df to get more accurate results

Additional details and impacted files
Files Coverage Δ
.../gregs/voidps/engine/client/PlayerAccountLoader.kt 71.87% <ø> (ø)
...s/voidps/engine/data/definition/AreaDefinitions.kt 11.42% <ø> (ø)
...gs/voidps/engine/entity/character/player/Player.kt 72.09% <100.00%> (ø)
...orld/gregs/voidps/engine/entity/obj/GameObjects.kt 63.18% <100.00%> (+0.20%) ⬆️
...n/kotlin/world/gregs/voidps/engine/event/Events.kt 53.33% <100.00%> (ø)
...dps/engine/map/collision/GameObjectCollisionAdd.kt 100.00% <100.00%> (ø)
...lin/world/gregs/voidps/engine/queue/ActionQueue.kt 58.82% <100.00%> (+0.49%) ⬆️
...in/kotlin/world/gregs/voidps/network/GameServer.kt 97.95% <100.00%> (ø)
...rld/gregs/voidps/network/login/protocol/Decoder.kt 100.00% <ø> (ø)
...twork/login/protocol/decode/APCoordinateDecoder.kt 100.00% <100.00%> (ø)
... and 102 more

... and 10 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #523      +/-   ##
============================================
+ Coverage     32.26%   32.48%   +0.22%     
- Complexity     4530     4540      +10     
============================================
  Files          1241     1243       +2     
  Lines         39931    39980      +49     
  Branches       8470     8480      +10     
============================================
+ Hits          12882    12986     +104     
+ Misses        24160    24097      -63     
- Partials       2889     2897       +8     
Components Coverage Δ
Content 23.42% <2.50%> (-0.03%) ⬇️
Engine 44.21% <49.55%> (+0.93%) ⬆️
Network 71.24% <96.55%> (+0.10%) ⬆️

@GregHib GregHib merged commit fde0d64 into main Apr 26, 2024
2 checks passed
@GregHib GregHib deleted the misc branch April 26, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant