Refactors tank fluid renderer to show fluid level #2487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
S P O T L E S S : 3 |
Spicierspace153
approved these changes
Dec 3, 2024
Spicierspace153
changed the title
|
what if maxAmount is 0 from an old supertank? |
|
I think it'll round up to infinity which might cause the item to look full or empty (idk how the engine handles infinity), but it'll only happen until the item is placed and mined again. |
screret
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This
Implementation Details
Math
Outcome
Much wow
Potential Compatibility Issues
Hardcoded the rotation because there are only 6 possible orientations, if we're going to allow players to rotate the tank it'll need some work.