Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Pool settings were lost after configuring the base factory. #1533

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

danielcweber
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 79.41%. Comparing base (81b03c0) to head (fa1f5f8).

Files Patch % Lines
...rc/Providers.Core/Factory/GremlinqClientFactory.cs 33.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             12.x    #1533      +/-   ##
==========================================
+ Coverage   79.22%   79.41%   +0.19%     
==========================================
  Files         252      252              
  Lines        6964     6962       -2     
  Branches     1660     1659       -1     
==========================================
+ Hits         5517     5529      +12     
+ Misses        647      634      -13     
+ Partials      800      799       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielcweber danielcweber merged commit fa1f5f8 into 12.x Mar 26, 2024
3 of 4 checks passed
@danielcweber danielcweber deleted the FixLostPoolSettings branch March 26, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant