Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit bindings parameter when bindings should not be included. #1755

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

danielcweber
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.

Project coverage is 83.20%. Comparing base (ec2a1a1) to head (677a277).
Report is 1 commits behind head on 12.x.

Files with missing lines Patch % Lines
...viders.Core/Extensions/GremlinqClientExtensions.cs 58.82% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             12.x    #1755      +/-   ##
==========================================
- Coverage   83.28%   83.20%   -0.08%     
==========================================
  Files         254      254              
  Lines        6832     6843      +11     
  Branches     1488     1489       +1     
==========================================
+ Hits         5690     5694       +4     
- Misses        496      502       +6     
- Partials      646      647       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielcweber danielcweber merged commit 677a277 into 12.x Oct 10, 2024
2 of 4 checks passed
@danielcweber danielcweber deleted the OmitBindings branch October 10, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant