Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle multiple DeleteRequest #76

Merged

Conversation

NiwakaDev
Copy link
Contributor

@NiwakaDev NiwakaDev commented Aug 11, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This PR generates DeleteRequests which has multiple DeleteRequests so that greptimdb can handle multiple grpc deletes.

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

GreptimeTeam/greptimedb#2150

@NiwakaDev NiwakaDev force-pushed the feat/multiple_delete_request branch from 63371c5 to 287aa5d Compare August 14, 2023 08:23
@NiwakaDev NiwakaDev force-pushed the feat/multiple_delete_request branch from 287aa5d to ec402b6 Compare August 14, 2023 15:59
Copy link
Contributor

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun merged commit f3a7cdf into GreptimeTeam:main Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants