Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add API to set time unit in a metric #36

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

SergeTupchiy
Copy link
Contributor

Hi team,

This a small and backward-compatible extension to allow reusing the same client for writing data to different tables with different time units.
Something similar to Go client: https://github.com/GreptimeTeam/greptimedb-client-go/blob/098f37980d47a1216de98643d658799bdd6df12b/docs/insert.md?plain=1#L84

This will allow reusing the same client for writing data to different tables with different time units.
@killme2008
Copy link
Contributor

Thank u! 👍

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 merged commit 519b7c2 into GreptimeTeam:main Jan 26, 2024
2 checks passed
@killme2008
Copy link
Contributor

@SergeTupchiy Thank you for your contribution. Could you please also update the README? Add the timeunit option to the Usage section.

@SergeTupchiy
Copy link
Contributor Author

SergeTupchiy commented Jan 26, 2024

Thanks @killme2008, done: #37
Would it be possible to tag a new release?

@killme2008
Copy link
Contributor

Thanks @killme2008, done: #37 Would it be possible to tag a new release?

Of course, I released v0.1.7 https://github.com/GreptimeTeam/greptimedb-client-erl/releases/tag/v0.1.7

Thank u!

@SergeTupchiy
Copy link
Contributor Author

Thank you very much @killme2008!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants