Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use dbconfig package to simplify the config generation #100

Merged
merged 2 commits into from
Jun 30, 2023
Merged

refactor: use dbconfig package to simplify the config generation #100

merged 2 commits into from
Jun 30, 2023

Conversation

zyy17
Copy link
Collaborator

@zyy17 zyy17 commented Jun 12, 2023

No description provided.

@zyy17 zyy17 mentioned this pull request Jun 16, 2023
Merged
@zyy17 zyy17 marked this pull request as ready for review June 16, 2023 15:14
@zyy17 zyy17 requested a review from daviderli614 June 16, 2023 15:14
@daviderli614 daviderli614 reopened this Jun 27, 2023
@zyy17 zyy17 requested a review from daviderli614 June 29, 2023 15:22
daviderli614
daviderli614 approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@daviderli614 daviderli614 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zyy17 zyy17 merged commit c264138 into GreptimeTeam:develop Jun 30, 2023
@zyy17 zyy17 deleted the refactor/use-dbconfig branch June 30, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daviderli614 daviderli614 daviderli614 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zyy17 @daviderli614