chore: add push image to aws ecr #155
Conversation
|
Fixed e2e fail in this PR. |
|
@daviderli614 Are you still working on that? |
WalkthroughThe recent updates to the GitHub Actions workflows enhance Docker image management by integrating AWS services. Key improvements include steps for configuring AWS credentials and authenticating with Amazon ECR, enabling seamless Docker image pushes to the AWS container registry. This integration streamlines deployment processes, allowing for better management and deployment of Docker images. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- .github/workflows/dev-build.yaml (3 hunks)
- .github/workflows/release.yaml (4 hunks)
Additional comments not posted (8)
.github/workflows/release.yaml (4)
59-61: Verify Amazon ECR login configuration.The Amazon ECR login configuration looks correct. Ensure that the action version is up-to-date and compatible with your workflow.
Verification successful
Verify Amazon ECR login configuration.
The previous attempt to verify the version of the
aws-actions/amazon-ecr-loginaction failed due to an incorrect command. We will now fetch the latest release version directly from the GitHub repository.
Amazon ECR login configuration is correct.
The Amazon ECR login configuration uses version
v2, which includes the latest releasev2.0.1. This confirms that the action version is up-to-date and compatible with your workflow.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the version of `aws-actions/amazon-ecr-login` action. # Test: Check the latest version of the action. Expect: Version `v2` to be the latest. gh actions list --repo aws-actions/amazon-ecr-loginLength of output: 102
Script:
#!/bin/bash # Description: Fetch the latest release version of `aws-actions/amazon-ecr-login` action. # Test: Check the latest release version. Expect: Version `v2` to be the latest. gh release list --repo aws-actions/amazon-ecr-login --limit 1Length of output: 105
79-80: Verify ECR image tags forgreptimedb-operator.The ECR image tags for
greptimedb-operatorlook correct. Ensure that theECR_REGISTRYvariable is correctly set in the workflow.
93-94: Verify ECR image tags forgreptimedb-initializer.The ECR image tags for
greptimedb-initializerlook correct. Ensure that theECR_REGISTRYvariable is correctly set in the workflow.
39-44: Ensure secure handling of AWS credentials.The AWS credentials configuration looks correct. Ensure that the secrets are securely stored and managed in GitHub Secrets.
.github/workflows/dev-build.yaml (4)
57-62: Ensure secure handling of AWS credentials.The AWS credentials configuration looks correct. Ensure that the secrets are securely stored and managed in GitHub Secrets.
70-72: Verify Amazon ECR login configuration.The Amazon ECR login configuration looks correct. Ensure that the action version is up-to-date and compatible with your workflow.
Verification successful
Amazon ECR login configuration is correct and up-to-date.
The action version
v2used in the workflow is compatible with the latest releasev2.0.1of theaws-actions/amazon-ecr-loginaction.
- The latest release tag is
v2.0.1.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the version of `aws-actions/amazon-ecr-login` action. # Test: Check the latest version of the action. Expect: Version `v2` to be the latest. gh actions list --repo aws-actions/amazon-ecr-loginLength of output: 102
Script:
#!/bin/bash # Description: Verify the latest version of `aws-actions/amazon-ecr-login` action. # Fetch the latest release tag from the GitHub repository curl -s https://api.github.com/repos/aws-actions/amazon-ecr-login/releases/latest | jq -r .tag_nameLength of output: 108
98-99: Verify ECR image tags forgreptimedb-operator-dev.The ECR image tags for
greptimedb-operator-devlook correct. Ensure that theECR_REGISTRYvariable is correctly set in the workflow.
113-114: Verify ECR image tags forgreptimedb-initializer-dev.The ECR image tags for
greptimedb-initializer-devlook correct. Ensure that theECR_REGISTRYvariable is correctly set in the workflow.
I changed code and push to private ECR. @zyy17 |
What change
When pulling images in aws eks, dockerhub rate limit, we use aws public container registry image replace dockerhub image.
Using the action push image to private AWS ECR.