Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add greptimedb Helm chart and refactor greptimedb-operator Helm chart #38

Merged
merged 2 commits into from
Oct 13, 2022

Conversation

zyy17
Copy link
Collaborator

@zyy17 zyy17 commented Sep 26, 2022

No description provided.

@zyy17 zyy17 added enhancement New feature or request CI/CD labels Sep 26, 2022
@zyy17 zyy17 self-assigned this Sep 26, 2022
@zyy17 zyy17 requested a review from daviderli614 September 26, 2022 11:28
@daviderli614
Copy link
Member

daviderli614 commented Sep 27, 2022

modify the crd file name, need to modify the command in the makefile

$(KUSTOMIZE) build config/crd > ${CHARTS_DIR}/greptimedb-operator/crds/greptimedbcluster.yaml

@zyy17 zyy17 requested a review from daviderli614 October 9, 2022 06:23
Copy link
Member

@daviderli614 daviderli614 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zyy17 added 2 commits October 13, 2022 12:03
… chart

* Add greptimedb Helm chart to deployment GreptimeDB cluster(including its dependency etcd Helm chart);

* Refactor greptimedb-operator Helm chart

  - Update version field in 'Chart.yaml': use '0.1.0' instead(by SemVer convention);

  - Split the files in 'templates/' by its resource type;

  - Unify the README style;

  - Refine naming of CRD files in 'crds/'(the filename is its CRD name);

Signed-off-by: zyy17 <zyylsxm@gmail.com>
Signed-off-by: zyy17 <zyylsxm@gmail.com>
@zyy17 zyy17 force-pushed the feat/add-greptimedb-helm branch from 567f39d to 5eea282 Compare October 13, 2022 04:05
@zyy17 zyy17 merged commit e009e96 into develop Oct 13, 2022
@zyy17 zyy17 deleted the feat/add-greptimedb-helm branch October 13, 2022 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants