feat(datatypes): implement VectorOp::take #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1115 +/- ##
===========================================
- Coverage 85.39% 84.99% -0.40%
===========================================
Files 459 477 +18
Lines 66931 70479 +3548
===========================================
+ Hits 57158 59907 +2749
- Misses 9773 10572 +799 |
killme2008
reviewed
Mar 5, 2023
v0y4g3r
reviewed
Mar 6, 2023
evenyag
reviewed
Mar 6, 2023
e1ijah1
requested review from
v0y4g3r and
evenyag
and removed request for
v0y4g3r
evenyag
reviewed
Mar 7, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: add take index method for VectorOp * chore: make clippy happy * chore: make clippy happy * chore: improve the code * chore: improve the code * chore: add take null test * chore: fix clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Add a new method
taketoVectorOpChecklist
Refer to a related PR or issue link (optional)
closes #1054