feat: region manifest checkpoint #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killme2008
changed the title
killme2008
force-pushed
the
feature/region-manifest-checkpoint
branch
from
74227b5 to
76eb90c
Compare
killme2008
force-pushed
the
feature/region-manifest-checkpoint
branch
from
76eb90c to
f0d5163
Compare
killme2008
requested review from
evenyag,
v0y4g3r and
waynexia
and removed request for
evenyag and
v0y4g3r
Codecov Report
@@ Coverage Diff @@
## develop #1202 +/- ##
===========================================
- Coverage 85.34% 84.95% -0.39%
===========================================
Files 494 495 +1
Lines 72513 72949 +436
===========================================
+ Hits 61888 61977 +89
- Misses 10625 10972 +347 |
waynexia
reviewed
Mar 22, 2023
Co-authored-by: Ruihang Xia <waynestxia@gmail.com>
Co-authored-by: Ruihang Xia <waynestxia@gmail.com>
Co-authored-by: Ruihang Xia <waynestxia@gmail.com>
Co-authored-by: Ruihang Xia <waynestxia@gmail.com>
|
@waynexia PTAL |
evenyag
reviewed
Mar 23, 2023
|
@evenyag PTAL, thank you. |
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* chore: adds log when manifest protocol is changed * chore: refactor region manifest * temp commit * feat: impl region manifest checkpoint * feat: recover region version from manifest snapshot * test: adds region snapshot test * test: region manifest checkpoint * test: alter region with manifest checkpoint * fix: revert storage api * feat: delete old snapshot * refactor: manifest log storage * Update src/storage/src/version.rs Co-authored-by: Ruihang Xia <waynestxia@gmail.com> * Update src/storage/src/manifest/checkpoint.rs Co-authored-by: Ruihang Xia <waynestxia@gmail.com> * Update src/storage/src/manifest/region.rs Co-authored-by: Ruihang Xia <waynestxia@gmail.com> * Update src/storage/src/manifest/region.rs Co-authored-by: Ruihang Xia <waynestxia@gmail.com> * chore: by CR comments * refactor: by CR comments * fix: typo * chore: tweak start_version --------- Co-authored-by: Ruihang Xia <waynestxia@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Impl region manifest checkpoint #170 . It compacts manifest actions and creates a snapshot for them. It will reduce disk consumption and speed up region recovery.
Main changes:
RegionManifestDataandRegionSnapshotetc. Please refer tosrc/storage/src/manifest/action.rs.Checkpointertrait and adds it intoManifestImpl.RegionManifestCheckpointerto do checkpointing for region manifest. When saving manifest actions every ten times, it will try to do a checkpoint.Checklist
Refer to a related PR or issue link (optional)
#170