refactor: make sql function in scripts return a list of column vectors #1243
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
The current
sql
function in the coprocessor returns a list of lists such aslist[list[vector]]
. The query result is a list ofRecordBatch
and it converts eachRecordBatch
into a list of column vectors. It's not friendly to users and batch splitting is not necessary at all for the coprocessor.So in this PR, I changed the return result type to
list[Vector]
: a list of column vectors. It concatenates all vectors from each batch into one vector for each column.For example:
It will return a list of two elements:
a
column and which is a vector.b
column and which is a vector too.It's much easier for users to process the query result.
Checklist
Refer to a related PR or issue link (optional)