Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adopt pgwire 0.12 and simplify encoding apis #1250

Merged
merged 2 commits into from
Mar 27, 2023

Conversation

sunng87
Copy link
Member

@sunng87 sunng87 commented Mar 27, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This patch updates pgwire 0.12. The major update is to simply data encoding APIs and respect client format requirement.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #1250 (b499140) into develop (5397a9b) will decrease coverage by 0.03%.
The diff coverage is 90.16%.

@@             Coverage Diff             @@
##           develop    #1250      +/-   ##
===========================================
- Coverage    85.20%   85.18%   -0.03%     
===========================================
  Files          495      495              
  Lines        72593    73349     +756     
===========================================
+ Hits         61852    62481     +629     
- Misses       10741    10868     +127     

@sunng87 sunng87 enabled auto-merge (squash) March 27, 2023 08:31
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunng87 sunng87 merged commit 7eb4d81 into GreptimeTeam:develop Mar 27, 2023
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* feat: adopt pgwire 0.12 and simplify encoding apis

* refactor: remove duplicated format match clause
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants