feat: implement create external table parser #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WenyXu
force-pushed
the
feat/external-table-parser
branch
from
cc06e4d to
a95f33e
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1252 +/- ##
===========================================
- Coverage 85.54% 85.15% -0.40%
===========================================
Files 495 496 +1
Lines 72790 73495 +705
===========================================
+ Hits 62269 62582 +313
- Misses 10521 10913 +392 |
evenyag
approved these changes
Mar 28, 2023
|
As discussed in #1272, We still need to add the engine type field. |
MichaelScofield
approved these changes
Mar 30, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* refactor: move parse_option_string to util * feat: implement create external table parser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Implement create external table parser
Checklist
Refer to a related PR or issue link (optional)
#1041